modularize the code, more robust error handling and languages support #118
Conversation
|
|
||
| let curatorMode = false; | ||
| let apiUrl = DEFAULT_API_URL; | ||
| let language: SupportedLanguage = 'en'; |
There was a problem hiding this comment.
I think we should set all three in constants
There was a problem hiding this comment.
they are user-adjustable, thus not constant
There was a problem hiding this comment.
I meant the defaults ;D
So the default apiURL comes from DEFAULT_API_URL in constants.ts, while language and curatorModes defaults are set here in state.s
There was a problem hiding this comment.
we can set them in state.ts if you prefer that. i think if i wanted to change them i would first look at constants.ts
| } | ||
|
|
||
| export function setLanguage(value: SupportedLanguage): void { | ||
| language = value; |
There was a problem hiding this comment.
I would group these last two with the ones above hydrateState
There was a problem hiding this comment.
they are convential setters and getters, it doesnt really make sense there imho
|
|
The two duplicated IDs spotted by the quality gate are the last things I see, we can merge after fixing them |
No description provided.